Skip to content

Viktoriia_L_MagicMessages#29

Open
Viktoria2609 wants to merge 7 commits intoAda-C23:mainfrom
Viktoria2609:main
Open

Viktoriia_L_MagicMessages#29
Viktoria2609 wants to merge 7 commits intoAda-C23:mainfrom
Viktoria2609:main

Conversation

@Viktoria2609
Copy link
Copy Markdown

Implemented core features of the chat application including message display, dynamic sender styling, and interactive like functionality with state management and count display.

Copy link
Copy Markdown

@yangashley yangashley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on react-chatlog!

Comment thread src/App.jsx Outdated

const toggleLike = (id) => {
const updatedMessages = messages.map((msg) =>
msg.id === id ? { ...msg, liked: !msg.liked } : msg
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We showed this approach in class, but technically, we're mixing a few responsibilities here. rather than this function needing to know how to change the liked status itself, we could move this update logic to a helper function. This would better mirror how we eventually update records when there's an API call involved.

In this project, our messages are very simple objects, but if we had more involved operations, it could be worthwhile to create an actual class with methods to work with them, or at least have a set of dedicated helper functions to centralize any such mutation logic.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the logic for toggling the liked status into a helper function called toggleLikedStatus() in a new messageHelpers.js file.

Comment thread src/App.jsx Outdated
setMessages(updatedMessages);
};

const countLikes = messages.filter((msg) => msg.liked).length;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea to filter down the data to the liked messages and use the list length as the count!

This approach works, but you'll typically see JS devs use reduce to calculate a value like this:

  const calculateTotalLikeCount = (chatData) => {
    return chatData.reduce((acc, chat) => {
      return chat.liked ? acc + 1 : acc;
    }, 0);
  };

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced the filter().length approach with a reduce()-based function calculateTotalLikeCount() to count total likes.

Comment thread src/App.jsx Outdated
<button className="like">🤍</button>
<p>{body}</p>
<p className="entry-time">
<TimeStamp time={timeStamp} />
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job using the provided TimeStamp component.

Comment thread src/App.jsx
import { useState } from 'react';

const App = () => {
const [messages, setMessages] = useState(chatMessages);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread src/App.jsx
<div id="App">
<header>
<h1> Magic Messages </h1>
<h1> {chatHeader} </h1>
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yangashley Hi Ashley! I accidentally clicked "Resolve conversation" earlier sorry about that! Here is your comment on the header "I like that you put your own spin on this project, it's cute!

An element missing from your project is the header "Chat Between X and Y". Here you have "Magic Messages".

@Viktoria2609 How would you create a header that reflects the screenshot below? It can be done by hardcoding the string in the h1 tag, but I'm wondering how would you programmatically get the names of the participants in the chat?

Please respond to this comment with your answer, thank you!" ---- so thank you for pointing out for this. I misunderstood the requirements . Now, I created a getParticipants() helper to dynamically generate the "Magic Messages between X and Y" header based on the message data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants